Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the the Hartree and Bohr value in SI, and defined the atomic units to GPa conversion. #76

Merged
merged 5 commits into from
May 8, 2024

Conversation

Minotakm
Copy link
Collaborator

@Minotakm Minotakm commented May 7, 2024

Added the the Hartree and Bohr value in SI, and defined the atomic units to GPa conversion.

Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Minotakm! Just a few nitpicks

src/qe_tools/_constants.py Outdated Show resolved Hide resolved
src/qe_tools/_constants.py Outdated Show resolved Hide resolved
src/qe_tools/_constants.py Outdated Show resolved Hide resolved
src/qe_tools/_constants.py Outdated Show resolved Hide resolved
@mbercx mbercx self-requested a review May 8, 2024 13:30
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @Minotakm. 🚀

@mbercx mbercx merged commit cf00438 into aiidateam:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants